Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17802

Shift Delete fails to permanently delete items & shift key sometimes sticks ON

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.15
    • Component/s: Shell
    • Labels:
      None

      Description

      Tested in 0.4.15-dev-3238-ge6fd41d and 0.4.15-dev-3120-g0233bb7.
      Video is attached. Log has nothing specific to indicate any problems.

      1) Click and Drag file to Recycle Bin NOT holding shift when released
         Expected to see "... send'file' to the Recycle Bin?"
         Results are seen as expected.
         Select "No"
      2) Click and Drag File to Recycle Bin holding shift when released.
         Expect to see "...want to delete 'file'?"
         Results are seen as expected.
         Select "No"
      3) Click and Drag File to Recycle Bin NOT holding shift when released
         Expected to see "... send'xxx' to the Recycle Bin?"
         Results are "...want to delete 'file'?" ("shift" key not released?)
         Select "No"
      4) Right click on File and select "Delete" while NOT holding the shift key
         Expected to see "... send'file' to the Recycle Bin?"
         Results are seen as expected.
         Select "No"
      5) Right Click on File and select "Delete" while holding the shift key
         Expect to see "...want to delete 'file'?"
         Results are "... send'xxx' to the Recycle Bin?" ("shift" key ignored?)
         Select "No"
      6) Right Click on File and Select "Delete" while NOT holding the shift key
         Expected to see "... send'file' to the Recycle Bin?"
         Results are seen as expected.
         Select "No"

      The above applies to not only 'files', but multiple files, folders and multiple folders.

      Related Issues:

      https://jira.reactos.org/browse/CORE-4365

      https://jira.reactos.org/browse/CORE-16333

      https://jira.reactos.org/browse/CORE-13363

      This is an old issue that Giannis fixed in SVN r69647.
      But this regressed in SVN r72512 and has been a problem since.

      Patch shift_delete_fix10.patchis attached. I will create a PR soon.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                DougLyons DougLyons
                Reporter:
                DougLyons DougLyons
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: