Details
Trivial Description
I was curious to backport Timos
0.4.15-dev-2951-g5d8e834
0.4.15-dev-2952-g41bc57d (nope, uninteresting for backport)
0.4.15-dev-2953-gcb9b538 (nope, uninteresting for backport)
So I investigated the historic testbots results on master gcc8.4.0
KVMdiff https://reactos.org/testman/compare.php?ids=78364,78368
VBoxdiff https://reactos.org/testman/compare.php?ids=78366,78367
And those looked innocent, good so far.
So I made a big-plan to port back from 0.4.15-dev-2951-g5d8e834 whatever would apply cleanly on top of 0.4.14-RC-105-g6375090.
TheBigPlan_unifiedDiff.patch
(which is only a subset of Timos commit, because some of the 'broken' implementations were not even existing in that older branch).
And then I checked the resulting buildlogs before and after 'theBigPlan' on MSVC2010SP1 16.0.40219.1, targetting x86:
configure -DENABLE_ROSTESTS=1 -DCMAKE_BUILD_TYPE=Release
|
ninja bootcd -j1
|
0.4.14-RC-105-g6375090_asIs_buildlog_MSVC2010SP1_rlsConfig.txt
0.4.14-RC-105-g6375090_theBigPlan_buildlog_MSVC2010SP1_rlsConfig.txt
The result was very disappointing, because I realized that ThePhysicist was mainly targetting to fix x64 build-issues with that commit, and the only win for my older branches are the fixes for
C:\0414rls\reactos\sdk\lib\crt\string\wtoi64.c(28) : warning C4146: unary minus operator applied to unsigned type, result still unsigned
|
C:\0414rls\reactos\sdk\lib\crt\string\wtoi64.c(194) : warning C4146: unary minus operator applied to unsigned type, result still unsigned
|
A pity, not much benefit for the old branches then.
But since I did all this effort, I decided to backport that minor fraction of improvements at least: crt_TheSmallPlan.patch