Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17993

mouse flickery improvement

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Untriaged
    • Priority: Minor
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Setup
    • Labels:

      Description

      Hello,
      As second part to reduce flikkery, I have reduce it by a little code change in file:
      \base\setup\welcome\welcome.c

      I don't know why is it there the point of interest, but it worked for me.
      The position for the change is near the lines: 1464, and 1477: (I comment the lines with C++ style comment's):

       

      ...
      if (nTopic != -1)
      {
       //INT nOldTopic = nTopic;
       nTopic = -1;
       /* Also repaint the buttons, otherwise nothing repaints... */
       
      // InvalidateRect(pTopics[nOldTopic]->hWndButton, NULL, TRUE);
       
      

      and there:

       

      ...
      /* Repaint the description panel */
       InvalidateRect(hWndMain, &rcRightPanel, TRUE);
       }
      ...
      

      The reason for this was, that the Win32API function InvalidateRect force a full repaint of the control, so it was called twice (which costs cpu times). And in this case - it was the mouse cursor on the desktop, starting with the welcome window.

      have a nice coding

       

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              paule32 paule32
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: