Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18021

Invalid use of SystemParametersInfo

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Trivial
    • None
    • None
    • None

    Description

      In base/setup/reactos/reactos.c line 79 there is an invalid use of SystemParametersInfo SPI_GETNONCLIENTMETRICS.  According to https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-systemparametersinfoa#spi_getnonclientmetrics the uiParam parameter must be set to sizeof(NONCLIENTMETRICS).  The code in question sets ncm.cbSize = sizeof(NONCLIENTMETRICS); but fails to pass sizeof(NONCLIENTMETRICS) to SystemParametersInfo.

      Not sure if there is an actual reason this particular function call is different, might need looking into.  In other places in the codebase it passes the correct parameters.

      This bug is present in some other locations as well:
      dll/win32/newdev/wizard.c line 1300 (https://doxygen.reactos.org/d5/dc8/newdev_2wizard_8c_source.html#l01291)
      dll/cpl/hdwwiz/hdwwiz.c line 54 (https://doxygen.reactos.org/de/d23/hdwwiz_8c_source.html#l00045)

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              -Tom- -Tom-
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: