Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18080

OpenOffice \\soffice.exe desktop shortcut is broken (icon not showing up)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.15
    • Shell

    Description

      ROS version: 0.4.15-dev-3893-g6cb1e57-x86-gcc

      Steps to reproduce the issue:

      • Install ReactOS.
      • Install OpenOffice or LibreOffice from RAPPS with the option of placing a shortcut on the Desktop
      • After the installation, the shortcut icon is not shown

      Image:

      Trying to change the icon, you will be able to choose the one that should be shown.

      The log:

      CShellLink.cpp:1705: Unexpected failure (hr)=80070057.
      CShellLink.cpp:1705: Unexpected failure (hr)=80070057.
      CShellLink.cpp:1705: Unexpected failure (hr)=80070057.
      CShellLink.cpp:1705: Unexpected failure (hr)=80070057.
      (/ntoskrnl/mm/balance.c:145) MM BALANCER: Removing access bit!
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      travellog.cpp:129: Unexpected failure (hResult)=80004005.
      CFSDropTarget.cpp:77: Unexpected failure (hr)=80070057.
      CShellLink.cpp:1705: Unexpected failure (hr)=80070057.
      

      It's a regression, previously the shortcuts were created properly:

      In fact, starting with a guilty revision, shortcuts are being created broken - even without actual files, broken ones will have no icon at all, while correct shortcuts will have a default program icon (see shortcuts.7z in CORE-18542).

      The problem is probably related to the fact that broken shortcuts have double slash in their destination path. The guilty commit implements PathResolveW and PathQualifyA/W functions (see CORE-12665).

      Attachments

        1. 1_before_calling_PathResolve.png
          56 kB
          hbelusca
        2. 2_after_jumping_over_PathResolve.png
          60 kB
          hbelusca
        3. 3_failure_to_create_shortcut.png
          38 kB
          hbelusca
        4. image-2022-10-26-15-53-39-479.png
          3 kB
          KRosUser
        5. image-2022-10-26-15-54-24-604.png
          1 kB
          KRosUser
        6. image-2022-10-26-15-54-46-412.png
          28 kB
          KRosUser
        7. image-2022-11-05-09-21-18-426.png
          3 kB
          KRosUser
        8. libreoffice icon.png
          25 kB
          julenuri
        9. OpenOffice confirmed 2794.png
          28 kB
          julenuri

        Issue Links

          Activity

            People

              katayama_hirofumi_mz Katayama Hirofumi MZ
              julenuri julenuri
              Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: