Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18140

THREADINFO structure is broken and abnormal

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.15
    • Win32SS
    • None

    Description

      1. Add the following code to the bottom of win32ss/user/ntuser/ime.c:

      _Static_assert(offsetof(THREADINFO, spwndDefaultIme) < 0xC1, "");
      _Static_assert(offsetof(THREADINFO, spwndDefaultIme) == 0xC1, "");
      _Static_assert(offsetof(THREADINFO, spwndDefaultIme) > 0xC1, "");
      

      2. Rebuild ReactOS. I got: THREADINFO-spwndDefaultIme-0xC1-abnormal.png

      Offset 0xC1 is not DWORD-aligned.
      So, I found the memory layout of THREADINFO structure is broken. Q.E.D.
      0.4.14 bc8a4ac

      Attachments

        1. THREADINFO-de38e3be61-FAILED.txt
          18 kB
          Katayama Hirofumi MZ
        2. THREADINFO-de38e3be61-STILL-FAILING.txt
          13 kB
          Katayama Hirofumi MZ
        3. THREADINFO-spwndDefaultIme-0xC1-abnormal.png
          23 kB
          Katayama Hirofumi MZ

        Issue Links

          Activity

            People

              hbelusca hbelusca
              katayama_hirofumi_mz Katayama Hirofumi MZ
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: