Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18319

[MMC] Use IDS_APPTITLE rather than Hardcoded text

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Fix
    • Trivial
    • None
    • None

    Description

      reactos-bootcd-0.4.15-dev-4946-ge9a129c-x86-gcc-lin-dbg

      https://github.com/reactos/reactos/blob/3fa57b8ff7fcee47b8e2ed869aecaf4515603f3f/base/applications/mmc/console.c#L153

      SetWindowText(Info->hwnd, TEXT("ReactOS Management Console"));

      while it should rely on

      https://github.com/reactos/reactos/blob/3fa57b8ff7fcee47b8e2ed869aecaf4515603f3f/base/applications/mmc/lang/en-US.rc#L41

      IDS_APPTITLE "ReactOS Management Console"

      to correctly support translations

      See how it is handled in other apps:
      https://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=String.%2BIDS_APPTITLE&sr=1

      Attachments

        Activity

          People

            Unassigned Unassigned
            KRosUser KRosUser
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: