Incorrect DHCP Lease Obtained/Expire time (DST related)

reactos-bootcd-0.4.15-dev-4946-ge9a129c-x86-gcc-lin-dbg

DHCP LeaseTime (obtained, expired) are shifted by 1hours compared to the system time and compared to the same scenario played on WinXPSP3.

leaseOptained = localtime(&pCurAdapter->LeaseObtained); => +1 compared to GMT is correctly applied so I assume the problem comes from the DST

Maybe should use SystemTimeToTzSpecificLocalTime (or similar) rather than localtime (which does not seems to manage DST) ?

Same issue affects "ipconfig /all"

Both are also consistent in WinXPSP3

As a conclusion, when starting ReactOS and WinXPSP3 in DST W-EU TZ (GMT+1) we observe a 1 h shift between the same DHCP lease being displayed by the 2 OSes

When executing both ipconfig in WinXPSP3, they both return consistant and correct values. Therefore, the cause is upstream, likely in the ReactOS DHCP client.

Note : Doing the same test on November 1st, after activation of DST, the problem is no longer visible, which suggest that DHCP client takes DST into consideration when it should not :