Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18391

FCW_STATUS not properly handled in filedlgbrowser

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Trivial
    • None
    • Wine
    • None

    Description

      reactos-bootcd-0.4.15-dev-5075-g34635e1-x86-gcc-lin-dbg

      When using FileBrowserDialog, logs are spammed with :

       

      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      fixme:(dll/win32/comdlg32/filedlgbrowser.c:619) ctrl id: 1
      

      This is due to FCW_STATUS to be sent ( https://git.reactos.org/?p=reactos.git&a=search&st=grep&s=FCW_STATUS ) but not managed in comdlg32 / filedlgbrowser.c where IShellBrowserImpl_SendControlMsg only manages FCW_TOOLBAR

      Guilty code : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/comdlg32/filedlgbrowser.c#l619 

      Not implemented upstream : https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/comdlg32/filedlgbrowser.c

      Btw, no status bar on this dialog. The problem is to understand why ReactOS is sending FCW_STATUS to the FileDlgBrowser

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            KRosUser KRosUser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: