Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18426

Search Pane : CopyToFolder ... does not copy but opens/execute files ! (from menu, not context menu). MoveTo does nothing

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.15
    • Shell

    Description

      reactos-bootcd-0.4.15-dev-5075-g34635e1-x86-gcc-lin-dbg

      Search for files in explorer.

      • Select a result (exe file).
      •  Context menu > CopyToFolder ... opens "Copy to" dialog
      •  Edit > CopyToFolder ... Executable is launched and no copy is proposed
      • : Right Click > CopyToFolder works fine
      •  Expected bahavior : open "CopyTo" dialog ** 

      Root cause : 

      dll/win32/shell32/CDefView.cpp : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/CDefView.cpp#l1957
      dll/win32/shell32/CDefaultContextMenu.cpp https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/CDefaultContextMenu.cpp#l1263

      eg : in CDefView::InvokeContextMenuCommand verb management is

      cmi.lpVerb = MAKEINTRESOURCEA(uCommand);

      while in CDefaultContextMenu::DoCopyToMoveToFolder

      lpici->lpVerb = "copyto"; (or "moveto")

      PATCH : find.patch

      Full log (for the "notepad" case in comment) : ReactOS.log

      Video : ROS-screen0.webm

       Similarly : Edit >"Move to" does nothing while it should (and right click cm does fine). Logs

      err:(dll/win32/shell32/CDefaultContextMenu.cpp:1274) Unhandled Verb 701dl
      CDefView.cpp:1523: Unexpected failure (hr)=80070057.
      CShellLink.cpp:1705: Unexpected failure (hr)=80070057.
      CShellLink.cpp:1705: Unexpected failure (hr)=80070057.
      CShellLink.cpp:1705: Unexpected failure (hr)=80070057.
      

      Attachments

        1. ROS-screen0.webm
          441 kB
        2. ReactOS.log
          38 kB
        3. image-2023-07-30-22-19-27-474.png
          image-2023-07-30-22-19-27-474.png
          26 kB
        4. image-2023-07-30-22-19-13-693.png
          image-2023-07-30-22-19-13-693.png
          32 kB
        5. image-2022-09-29-21-24-12-289.png
          image-2022-09-29-21-24-12-289.png
          69 kB
        6. find.patch
          0.6 kB

        Issue Links

          Activity

            People

              katayama_hirofumi_mz Katayama Hirofumi MZ
              KRosUser KRosUser
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: