Description
reactos-bootcd-0.4.15-dev-5327-gc8ef276-x86-gcc-lin-dbg
Incorrect rendering of disabled "checked" checkboxes
Should use "grey" (see WinXP, left) while it uses "black" (ReactOS 0.4.15, right)
Code section of interest : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/comctl32/button.c#l1628
then
- https://git.reactos.org/?p=reactos.git;a=blob;f=win32ss/user/ntuser/draw.c#l746 where IntGetSysColor(COLOR_WINDOWTEXT) should only be used when enabled (and replaced by the correct "grey" when in disabled state)
- https://git.reactos.org/?p=reactos.git;a=blob;f=win32ss/user/user32/windows/draw.c#l762 where COLOR_WINDOWTEXT should only be used when enabled (and replaced by the correct "grey" when in disabled state)
With proposed patch :