Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18642

hhpcomp : Useless comparison (always false)

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Trivial
    • 0.4.15
    • SDK
    • None

    Description

      reactos-bootcd-0.4.15-dev-5369-g51f7891-x86-gcc-lin-dbg

      https://git.reactos.org/?p=reactos.git;a=blob;f=sdk/tools/hhpcomp/chmc/chmc.c#l943

      "if ((wsize_code < 15) || (wsize_code > 21))" is useless as wsize_code is constant equal to 16

      likely copy paste from https://git.reactos.org/?p=reactos.git;a=blob;f=sdk/tools/hhpcomp/lzx_compress/lzx_layer.c#l1189

      Found thanks to https://lgtm.com/projects/g/reactos/reactos

       

      Attachments

        Activity

          People

            Serge Gautherie Serge Gautherie
            KRosUser KRosUser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: