Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18791

Improve NDIS_TAG usages

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • Networking
    • None

    Description

      1. Inline + __LINE__ looks "surprising":
        Use NDIS_TAG only, or some constant defines?
      2. Then ExFreePool() calls could be upgraded to check the tag.

      –

      https://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=NDIS_TAG

      drivers/network/ndis/include/ndissys.h
      		 
        29 #define NDIS_TAG  0x4e4d4953
      		 
      drivers/network/ndis/ndis/protocol.c
      		 
       928     RegistryPathStr = ExAllocatePoolWithTag(PagedPool, sizeof(SERVICES_KEY) + ProtocolCharacteristics->Name.Length + sizeof(LINKAGE_KEY), NDIS_TAG + __LINE__);
      		 
       963             KeyInformation = ExAllocatePoolWithTag(PagedPool, sizeof(KEY_VALUE_PARTIAL_INFORMATION) + ResultLength, NDIS_TAG + __LINE__);


      These were added on r12196.

      Attachments

        Activity

          People

            Unassigned Unassigned
            Serge Gautherie Serge Gautherie
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: