Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18848

Regression of old ws2_32:sock test by incomplete and nonfunctional mockup-code added 0.4.12-dev-693-g2b1f6c8

    XMLWordPrintable

Details

    Description

      Prior to 0.4.9-dev-616-g67c6659 the test for ws2_32:sock completed successfully.
      This commit was titled "[WS2_32_WINETEST] Sync with Wine Staging 3.3".
      It caused the test to crash because of some new added wine tests.
      See (https://reactos.org/testman/compare.php?ids=60023,60025) for ws2_32:sock.

      But the old ws2_32:sock test was able to run until the commit of 0.4.12-dev-693-g2b1f6c8 .
      Pierre Schweitzer made this commit and titled it as follows:
      "[MSAFD] Add an initial implementation of SIO_GET_EXTENSION_FUNCTION_POINTER IOCTL"
      This was related to CORE-14966 (https://jira.reactos.org/browse/CORE-14966).
      Pierre noted "this doesn't fix Steam running on ReactOS".

      Here is a patch to two lines of code can fix the old test. dllmain_c_01.patch
      With this change, the the old wine ws2_32_winetest:sock test can finish successfully.

      An executable of the old winetest ws2_32_winetest is attached here. ws2_32_winetest-0.4.9-dev-615.exe
      I plan to do a testbot run shortly.

      Attachments

        1. combined_winsock_01.patch
          3 kB
          DougLyons
        2. dllmain_c_01.patch
          1 kB
          DougLyons
        3. Win2K3.webm
          1.41 MB
          DougLyons
        4. ws2_32_winetest-0.4.9-dev-615.exe
          404 kB
          DougLyons

        Issue Links

          Activity

            People

              DougLyons DougLyons
              DougLyons DougLyons
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: