Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18874

[NETSHELL] 2nd stage setup dialog starts to crop text as soon as we toggle the radiobutton, unhidden by 0.4.10-dev-466-g35f62fc

    XMLWordPrintable

Details

    Description

      During 2nd stage setup there is a dialog that allows you to select how to perform the network setup. It is not implemented in [SYSSETUP.DLL], but in some other dll, maybe it is within netshell.dll.
      I tested this with german localization here, but most likely other languages are affected by the same bug.

      0.4.15-dev-5784-g2aea4ab_affected.webm
      0.4.15-dev-5784-g2aea4ab_affected.log (log doesn't log anything interesting)

      It is a regression, as it was still fine in
      0.4.7-release-226-ge3ee3d3_wasStillFine.webm

      I do suspect that the controls resources did not change in this regard so much since then, I guess maybe that the cropped text was a bit too close to the radiobutton always already. I could imagine that the problem got unhidden by a later commit into another module that influenced how the dialogs sizes were rendered But this is only a first guess, I did not bisect yet.. Would need a proper bisect to say for sure, whether that was the unhider or something else.

      Can we test that netshell? dialog from Windows somehow? Maybe with some fancy rundll commandline?

      Attachments

        Issue Links

          Activity

            People

              katayama_hirofumi_mz Katayama Hirofumi MZ
              reactosfanboy reactosfanboy
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: