Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18909

Move/Copy to folder should not be displayed when unable to recover file name

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.15
    • Shell
    • None

    Description

      reactos-bootcd-0.4.15-dev-5900-g14cf589-x86-gcc-lin-dbg

      Attempt to use "Move/Copy to" from toolbar on items that can't be moved and are not actual files (RecycleBin, My Computer) : 

      Shows '(file)' and of course finally does nothing.

      Expected behavior, does not show dialog and fails gracefully.

      Cause : 

      CMoveToMenu::DoMoveToFolder : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/CMoveToMenu.cpp#l228

      does not detect if DoGetFileTitle() fails and return its default value : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/CMoveToMenu.cpp#l194

      Same bug affects : CCopyToMenu::DoCopyToFolder https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/CCopyToMenu.cpp#l229

      Attachments

        Activity

          People

            katayama_hirofumi_mz Katayama Hirofumi MZ
            KRosUser KRosUser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: