Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18959

WS2_32 masks provider errors not returning WSASYSCALLFAILURE

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Major
    • None
    • Networking
    • None

    Description

      calls to LSP Provider from send.c and other parts of WS2_32 source seem to mishandle provider errors returning incorrect ErrorValue when they occur.

      currently these routines have code similar to this

                  /* If everything seemed fine, then the WSP call failed itself */
                  if (ErrorCode == NO_ERROR)

      {                 ErrorCode = WSASYSCALLFAILURE;              }

      the if condition is reversed, it should be ErrorCode != NO_ERROR.

      As a result of this inversion SOCKET_ERROR is returned, but call to GetLastError does not identify the provider as the source of the communication failure.

      Attachments

        Activity

          People

            Unassigned Unassigned
            bugdude bugdude
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: