Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-18962

Refactor NT PNP Firmware Mapper functions

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Minor
    • 0.4.15
    • NTCore
    • None

    Description

      Firmware Mapper functions are currently placed in the pnpmgr.c file:

      • IopUpdateRootKey
      • IopIsFirmwareMapperDisabled
      • IopEnumerateDetectedDevices

      TODO steps in this task:

      1. They should be moved to a separate file. - fixed in 0.4.15-dev-6002-g484c26d
      2. Fix coding style for IopEnumerateDetectedDevices function. - fixed in 0.4.15-dev-6003-g6e3ad04
      3. IopEnumerateDetectedDevices has to be refactored - it takes more than 500 lines, can be potentially rewritten with less code using helper functions. - fixed in 0.4.15-dev-6043-g85ca8af

      Attachments

        1. p2.patch
          14 kB
        2. p1.patch
          0.5 kB

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. CORE-18963 Assign correct PnP IDs to the devices detected by NTLDR/FreeLdr

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              binarymaster Stas'M
              binarymaster Stas'M
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: