Details
-
Bug
-
Resolution: Fixed
-
Major
-
0.4.10-dev-289-g79ad68d https://github.com/reactos/reactos/commit/79ad68ddc3a47f55e348af5b9d47242b5ca72877
Description
Since the guilty revision 0.4.10-dev-289-g79ad68d we do have ~350 additional compiler warnings for the GCC toolchain in release configuration
As an example run:
configure -DCMAKE_BUILD_TYPE=Release
|
ninja d3dcompiler_43
|
you will then get many:
[7927/12211] Building C object dll/directx/wine/d3dcompiler_43/CMakeFiles/d3dcompiler_43.dir/asmshader.tab.c.obj
|
asmshader.tab.c: In function 'asmshader_parse':
|
asmshader.y:318:1: warning: array subscript is above array bounds [-Warray-bounds]
|
...
|
and it affects all the .y files that want to log something.
The reason is that those files came pre-translated in the past, and they seem to rely on the directory layout that is hard-baken into the pretranslated files.
It affects:
releases/0.4.14-release-74-g42d3931
releases/0.4.13-release-142-g94c4d9d
releases/0.4.12-release-171-g32cabbf
releases/0.4.11-release-179-gd330f42
It does not affect releases/0.4.10-release-196-g84300ee (because I reverted the guilty rev for releases/0.4.10 via 0.4.10-RC-10-g1351f4c )
The issue does not longer happen on master head, and it with almost certainty got fixed by
0.4.15-dev-1648-g5375e33
I will not port back that anytime soon, so I created this ticket mostly to remind myself to not port back the fix for CORE-14839 further yet.
Although 0.4.10-dev-289-g79ad68d + its addendum 0.4.12-dev-29-g3de04cc were nice to harmonize the different logging of
GCC4.7.2dbg Windows-host:
(../ntoskrnl/kd/kdio.c:106) ReactOS 0.4.10 (Build 20230618-0.4.10-release-196-g84300ee) (Commit 84300eeddb478e0ef2021f3ae5736912cf86fd06)
|
GCC4.7.2dbg Linux-host:
(../../ntoskrnl/kd/kdio.c:106) ReactOS 0.4.10 (Build 20221114-0.4.10-release-160-gc5c0ea2) (Commit c5c0ea2e4fa0bc1cf226b11696f6c935185be628)
|
to
(ntoskrnl/kd/kdio.c:106) ReactOS 0.4.10 (Build 20221114-0.4.10-release-160-gc5c0ea2) (Commit c5c0ea2e4fa0bc1cf226b11696f6c935185be628)
|
Attachments
Issue Links
- blocks
-
CORE-14839 Regression: paths to source files in putty + gcc logs are cut off
- Resolved
- relates to
-
CORE-14512 Use NEW policies for CMP0005 and CMP0018
- Resolved
-
CORE-15991 [VSSolution] Loads of "error C2065: 'REACTOS_SOURCE_DIR' : undeclared identifier"
- Resolved