Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-19013

Control Panel Applets that use CPL_DYNAMIC_RES Icons Not Displayed

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • Shell
    • None

    Description

      I have found two different applications that use the features of CPL_DYNAMIC_RES in their Control Panel applets that do not show their icons correctly. Due to this bug depending upon uninitialized memory, the effects are not consistent, but normally these application have a blank or 'Document' icon when the CPL files are copied into the C:\ReactOS\system32 directory.
      One of these (SwitchIt) is related to CORE-18535. In its case, it normally shows a "Documents" icon and after the proposed fix, it has a blank icon. There are different versions of SwitchIt such as 2.1 and 2.5 that have different characteristics such as resource numbers for their normal icons, but they behave similarly regarding their Control Panel Icons.
      Switchit 2.1 is available as an attachment from CORE-18535. I have attached the ERAM code here as ERAMN220.7z.
      katayama_hirofumi_mz has provided a Github example of the ERAM in an updated and translated version here as well: https://github.com/katahiromz/ERAM.

      Current display in ReactOS:

      After Patch:

      Attachments

        1. control.patch
          0.7 kB
        2. ERAM-and-SwitchIt-CPLs-02.png
          ERAM-and-SwitchIt-CPLs-02.png
          125 kB
        3. ERAM-and-SwitchIt-CPLs-02-patched.png
          ERAM-and-SwitchIt-CPLs-02-patched.png
          119 kB
        4. eramkhmz.cpl
          34 kB
        5. ERAMN220.7z
          36 kB
        6. ERAMNT.CPL
          27 kB
        7. SWITCHIT.CPL
          158 kB
        8. switchit-07.patch
          0.7 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              DougLyons DougLyons
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: