Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-19107

Improve cursoricon Fail Message when finding a PNG icon

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 0.4.15
    • None
    • None

    Description

      When opening RAPPS there is a sequence of messages sent to the debug log as follows:

      err:(win32ss/user/user32/windows/cursoricon.c:201) (1196314761): unknown/wrong size for header
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:201) (1196314761): unknown/wrong size for header
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:201) (1196314761): unknown/wrong size for header
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:201) (1196314761): unknown/wrong size for header
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:201) (1196314761): unknown/wrong size for header
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:201) (1196314761): unknown/wrong size for header

      It seemed odd that all of these had the same values which was supposed to be the biSize of the icon. Upon investigation, I found that this was caused by the ICO files having a PNG embedded. To improve the error message and have it report correctly, I added the attached patch. Afterward the output changes to the following:

      err:(win32ss/user/user32/windows/cursoricon.c:209) Cannot yet display PNG icons
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:1395) Failing File is 
          'C:\Documents and Settings\Administrator\Local Settings\Application Data\RApps\appdb\icons\jdk8.ico'.
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:209) Cannot yet display PNG icons
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:1395) Failing File is 
          'C:\Documents and Settings\Administrator\Local Settings\Application Data\RApps\appdb\icons\jdk8.ico'.
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:209) Cannot yet display PNG icons
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:1395) Failing File is 
          'C:\Documents and Settings\Administrator\Local Settings\Application Data\RApps\appdb\icons\codeblocks.ico'.
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:209) Cannot yet display PNG icons
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:1395) Failing File is 
          'C:\Documents and Settings\Administrator\Local Settings\Application Data\RApps\appdb\icons\jdk8.ico'.
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:209) Cannot yet display PNG icons
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:1395) Failing File is 
          'C:\Documents and Settings\Administrator\Local Settings\Application Data\RApps\appdb\icons\jdk8.ico'.
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:209) Cannot yet display PNG icons
      		 
      err:(win32ss/user/user32/windows/cursoricon.c:1395) Failing File is 
          'C:\Documents and Settings\Administrator\Local Settings\Application Data\RApps\appdb\icons\flashplayer32.ico'.

      Attachments

        1. cursoricon_PNG_error_display_05.patch
          2 kB
        2. renpy.ico
          72 kB
        3. renpy-1.ico
          72 kB
        4. sublime_text.ico
          36 kB
        5. winrar.ico
          67 kB
        6. winrar-1.ico
          67 kB

        Issue Links

          relates to

          New Feature - A new feature of the product, which has yet to be developed. CORE-18385 Support NT6 (Vista) PNG icons

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Open

          Activity

            People

              DougLyons DougLyons
              DougLyons DougLyons
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: