Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-19284

"Default/Dummy" description in Network Properties when no components are there

    XMLWordPrintable

Details

    Description

      reactos-livecd-0.4.15-dev-6811-gbdae8cf-x86-gcc-lin-dbg

      Unhidden by CORE-18349

      Cause : SendDlgItemMessageW(hwndDlg, IDC_DESCRIPTION, WM_SETTEXT, 0, (LPARAM)pItem->szHelp); is only call on LVN_ITEMCHANGING. https://git.reactos.org/?p=reactos.git;a=blob;f=dll/shellext/netshell/lanconnectui.cpp;hb=bdae8cf96695fe1e7302da46227052d0faf822ef#l348 

      Therefore, if NO item is there, the default text from the ressource file is displayed.

      Either IDC_DESCRIPTION shall be set to "" in all lang (saves size) OR SendDlgItemMessageW to be sent with empty text on initialization of the page with processing of WM_INITDIALOG here : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/shellext/netshell/lanconnectui.cpp;hb=bdae8cf96695fe1e7302da46227052d0faf822ef#l264 

      Attachments

        Issue Links

          Activity

            People

              reactosfanboy reactosfanboy
              KRosUser KRosUser
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: