Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-19402

Color picker uses out of bound HSL values

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Trivial
    • 0.4.15
    • Wine
    • None

    Description

      reactos-bootcd-0.4.15-dev-7322-g3558b7b-x86-gcc-lin-dbg

      • Launch Paint > Custom Colors
      • Set HSV to max value by typing 999
      • Automatically sets to 239, 240, 240
      • Click on the 2D spectrum
      • Lum gets to 999
      • Click on right ribbon
      • H & S gets to 999 and ribbon gets crazy

      Faulty code is CC_CheckDigitsInEdit where the raw value is returned even when exceeding max value https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/comdlg32/colordlg.c;h=1e8c26bf3244203ffac37d3ebcb3c7a52cb961e6;hb=f380a5104034604de6a8ca3d7b90a15a459e894b#l422 

      Fixed by patch : colorpickerlim.patch

      See : ROS-screen0.webm

      Attachments

        1. colorpickerlim.patch
          0.4 kB
          KRosUser
        2. image-2023-12-24-16-36-52-218.png
          14 kB
          KRosUser
        3. image-2023-12-24-16-51-54-092.png
          14 kB
          KRosUser
        4. ROS-screen0.webm
          535 kB
          KRosUser

        Activity

          People

            katayama_hirofumi_mz Katayama Hirofumi MZ
            KRosUser KRosUser
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: