Browse for Folder : Button looses focus when using Keyboard navigation

reactos-bootcd-0.4.15-dev-8079-g5db69da-x86-gcc-lin-dbg

Now that keyboard navigation is fixed thanks to https://github.com/reactos/reactos/pull/6853 from gato_dev it unhides another bug :

• Open "Browse for folder"
• Use tab to put focus on "Create new folder"
• Use Right/Left to move focus : it works
• Use Right when already on Rightmost position (or Left when already on Leftmost position)
• Focus is lost and goes nowhere, and log loops on (already seen in CORE-10308)

(win32ss/user/ntuser/caret.c:52) err: Failed to get bitmap dimensions 

• Focus should stay on the Rightmost (resp. Leftmost) button position
• Video : ROS-screen0.webm

Inspecting the code, it "focus" is attempted to be passed to the window's sizing handle which is a VS_VISIBLE ScrollBar control

W2K3 : WS_GROUP is set. Removing WS_GROUP with WinSpy at runtime leads to the same the bug.

ReactOS : WS_GROUP not set. Forcing WS_GROUP with WinSpy at runtime fixes the bug.

But it clearly shows the bug :

• In W2K3 the WS_GROUP is set, and therefore it's NOT in the "buttons" group thus key navigation never jump to this scrollbar
• In ReactOS (see Winspector screenshot) WS_GROUP is NOT set, thus considered as the next control after the "cancel" button
• By "removing" WS_GROUP in W2K3 is facing the same bug as in ReactOS
• https://git.reactos.org/?p=reactos.git;a=blob;f=sdk/include/reactos/ui/layout.h;hb=a25a4eb7b8c5909a852a7a9a4bd0f19783f9feb0#l89 : WS_GROUP to be added ?

PATCH : WS_GROUP.patch