Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-19684

Installer of Ad Muncher incorrectly displays "X" close button as disabled when themed

    XMLWordPrintable

Details

    Description

      Tested on build 0.4.15-dev-8327-g71bed0f, can be reproduced on LiveCD.

      Steps to reproduce:

      • Download: https://www.admuncher.com/static/files/AM-Install.exe
      • Enable theming in Display properties, preferably set Lunar
      • Run the installer
      • Expected: The "X" close button is displayed as enabled
      • Observed: It's displayed as disabled (greyed out), but works as enabled

      Comment by I_Kill_Bugs from CORE-11569:

      Also, the theme nonclient code doesn't have the same checks which allows the close to continue and end the program. The theme code needs to be updated to have the same checks, but that doesn't explain why the class has the CS_NOCLOSE flag to begin with.

      Debug log doesn't show anything interesting, but I attached it anyway: 0.4.15-dev-8327-g71bed0f.txt

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. CORE-17203 Regedit + theme "Luna" - dialog for adding information to the registry "cross" (close) active - this is incorrect

          • Major - Major loss of function.
          • Resolved

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. CORE-12285 Reactos Theming Issues [Themes / Theme-ing / Themeing]

          • Major - Major loss of function.
          • Untriaged
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-11569 Title Bar "X" Close Button fails with Classic Theme using Ad Muncher

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-11541 Ad Muncher isn't filtering ads like it should be

          • Major - Major loss of function.
          • Untriaged

          Activity

            People

              hbelusca hbelusca
              binarymaster Stas'M
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: