Details
-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
None
Description
reactos-bootcd-0.4.16-dev-173-g467efcb-x86-gcc-lin-dbg
- Open Explorer to a registry key
- Open Favirote Band and add this key as favorite
- Open "Organize"
- Attempt to change the icon for this .lnk (click on Change Icon button)
- Nothing happens and log says
err:(win32ss/user/user32/windows/message.c:1556) Exception Dialog unicode 7AF7388C Msg 273 pti B17E0008 Wndpti B17E0008 |
- Related to CORE-19971
- Code of interest: CShellLink::OnCommand in dll/win32/shell32/CShellLink.cpp https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/CShellLink.cpp;hb=eafa7c68b61ce250aee7c7a0cb498a80f1e2a17b#l2916 in particular not checking return value of FindExecutableW which likely fails (and function should exit in such a case).