Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-20218

[FORMAT] format.c: Review StdOut usages for errors

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • 0.4.16
    • Applications
    • None

    Description

      It looks like some errors are reported to StdOut instead of StdErr.
      Fix these cases, or add a comment if intended.

      https://github.com/reactos/reactos/blob/master/base/system/format/format.c

      Example:

          if (!LoadFMIFSEntryPoints())
          {
              ConPrintf(StdOut, szMsg, ProgramName, L"");
              return;
          }
      // ...
          if (!LoadFMIFSEntryPoints())
          {
              ConResPuts(StdErr, STRING_FMIFS_FAIL);
              return -1;
          }
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            Serge Gautherie Serge Gautherie
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: