Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-20395

Refactor LPK initialization

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • None
    • None

    Description

      Currently LPK initialization (LPK_ApplyMirroring) is done during process attach.

      This can be problematic.

      See https://github.com/reactos/reactos/pull/8493

      peterooch (comment):

      After seeing all the bugs, maybe a better idea is to move the mirroring check / apply to be called from `GdiInitializeLanguagePack` and then `LpkInitialize` (via dynamic load)? (GdiInitializeLanguagePack -> LpkInitialize -> LPK_ApplyMirroring) Then this would more explicit than doing it implied via DLL attach.

      This is how its done in win2k3 gdi + lpk implementation, the mirroring check itself also uses ntdll APIs and not the version APIs I guess for the same reasons stated in PR.

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            ThePhysicist Timo Kreuzer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: