Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-20434

Wrong alphanumerical sorting when accents on Upper case (É) in Regedit, Explorer

    XMLWordPrintable

Details

    Description

      reactos-bootcd-0.4.16-dev-2132-g3885311-x86-gcc-lin-dbg

      Wrong alphanumerical sorting when accents on Upper case

      "É" is should be considered as E but is not, either considered before A or after Z

      Guilty code is the use of _wcsicmp / SHELL_StrCmpLogical in CompareUiStrings inline here https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shell32/folders/CFSFolder.h;hb=3885311c85dd715210e95b03f6169b62ff992184#l132

      Guilty code is the use of memcmp in CompareFunc here https://git.reactos.org/?p=reactos.git;a=blob;f=base/applications/regedit/listview.c;hb=3885311c85dd715210e95b03f6169b62ff992184#l447

      Win 11 (A < É < F)

      Listbox LBS_SORT is behaving OK : 

      so LISTBOX_lstrcmpiW, relying on CompareStringW is likely a good source of inspiration: https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/comctl32/listbox.c;hb=3885311c85dd715210e95b03f6169b62ff992184#l887

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-20442 Wrong alphanumerical sorting when accents on Upper case (É) in Extension dialog

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              katayama_hirofumi_mz Katayama Hirofumi MZ
              KRosUser KRosUser
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: