Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-20499

REGRESSION: Desk.cpl unduly reverts to default background

    XMLWordPrintable

Details

    Description

      reactos-bootcd-0.4.16-dev-2299-g492aeb6-x86-gcc-lin-dbg

      Guilty commit: https://github.com/reactos/reactos/commit/3016c40dc72e25a7354d7ae50b109fa0454ba24f by katayama_hirofumi_mz in https://github.com/reactos/reactos/pull/8670

      • Create a .bmp
      • Open desk.cpl
      • Set it as background in desk.cpl
      • click "OK"
      • .bmp used as background,  and "Wallpaper" regkey is set to path to the .bmp file
      • Open desk.cpl
      • .bmp is "selected" in list (default) ...
      • ... but rendered with "default" (blue)

      • change nothing, click "OK"
      • default background is set and "Wallpaper" regkey is set to NULL string
      • re-open desk.cpl
      • .bmp is no longer listed

      Guilty code is : https://git.reactos.org/?p=reactos.git;a=blob;f=dll/cpl/desk/background.c#l345 where LVIS_SELECTED is set before adding the file to the list while it used to be after the file addition before the guilty commit, and now triggering LVN_ITEMCHANGED at the incorrect time.

      Attachments

        Issue Links

          Activity

            People

              katayama_hirofumi_mz Katayama Hirofumi MZ
              KRosUser KRosUser
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: