Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-20577

[shlwapi] ReactOS not recognized as XPorGreater

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • None

    Description

      reactos-bootcd-0.4.16-dev-2647-ge5bf20d-x86-gcc-lin-dbg

      This bug from upstream Wine ( https://bugs.winehq.org/show_bug.cgi?id=55324 ) also affects ReactOS: "IsOS" API return "FALSE" for OS_XPORGREATER if used with version 6.0, making ReactOS Vista+ bringup to be recognized as "Not XP or Greater"

      Guilty code https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/shlwapi/ordinal.c;hb=d9d27f89433239bbb26260b8ae331b2a13bbfbbf#l4307

      Trivial fix, as proposed in patch attached to Wine Ticket

           case OS_XPORGREATER:
      -        ISOS_RETURN(platform == VER_PLATFORM_WIN32_NT && majorv >= 5 && minorv >= 1);
      +        ISOS_RETURN(platform == VER_PLATFORM_WIN32_NT && ( (majorv >= 5 && minorv >= 1) || majorv >= 6) );

      Attachments

        Activity

          People

            Unassigned Unassigned
            KRosUser KRosUser
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: