Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-20655

Half-Life (retail): missing orange menu entries on main menu

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • None

    Description

      (Tracking discovery tests performed by Zombiedeth for the issue following whindsaks and his tests)

      Expected

      Actual

      (Failed) tests so far:

      • using a different renderer has no effect (-gl, -soft)
      • using non direct blitting has no effect (-nodirectblit)
      • forcing 32bpp (-32bpp) or using the desktop in 16-bit or 8-bit has no effect
      • replacing ddraw.dll (since software mode still uses that) with xp ddraw.dll has no effect
      • changing fontface on valve/resource/GameUIScheme.res from Tahoma (half life takes the system font as default) to Verdana (like in XP) has no effect
      • log has no relevant data

      [MSG ] ShimInfo(ExePath(C:\SIERRA\Half-Life\hl.exe))
      		 
      [MSG ] ShimInfo(Layer(WINXPSP3))
      		 
      [MSG ] ShimInfo(Complete)
      		 
      (/dll/win32/kernel32/client/loader.c:386) LoadLibraryExW(Steam.dll) failing with status c0000135
      		 
      err:(/dll/directx/wine/wined3d/context.c:1820) >>>>>>> GL_INVALID_ENUM (0x500) from extension detection @ ../src/dll/directx/wine/wined3d/directx.c / 4313.
      		 
      fixme:(/dll/directx/wine/wined3d/directx.c:2591) No card selector available for card vendor 0000 (using GL_RENDERER "Mesa ReactOS SW Implementation").
      		 
      err:(/dll/directx/wine/wined3d/directx.c:6747) You are using the backbuffer for offscreen rendering. This is unsupported, and will be removed in a future version.
      		 
      (/win32ss/gdi/eng/device.c:695) err: Could not open device \Device\Video1, 0xc0000022
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      err:(/win32ss/user/imm32/imm.c:962) hImc was NULL
      		 
      err:(/win32ss/user/imm32/imm.c:1052) pClientImc was NULL
      		 
      err:(/win32ss/user/imm32/imm.c:962) hImc was NULL
      		 
      err:(/win32ss/user/imm32/imm.c:962) hImc was NULL
      		 
      err:(/win32ss/user/imm32/imm.c:1052) pClientImc was NULL

      and next with native ddraw

      [MSG ] ShimInfo(ExePath(C:\SIERRA\Half-Life\hl.exe))
      		 
      [MSG ] ShimInfo(Layer(WINXPSP3))
      		 
      [MSG ] ShimInfo(Complete)
      		 
      (/dll/win32/kernel32/client/loader.c:386) LoadLibraryExW(Steam.dll) failing with status c0000135
      		 
      (/win32ss/gdi/eng/device.c:695) err: Could not open device \Device\Video1, 0xc0000022
      		 
      (/win32ss/reactx/ntddraw/ddraw.c:148) Calling dxg.sys pfnDdCreateDirectDrawObject
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:133) ReactX Calling : DxEngLockDC
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:456) ReactX Calling : DxEngGetDCState, type: 3
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:483) retVal: e178f3f0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:286) ReactX Calling : DxEngGetHdevData, Type: 12
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:289) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:343) requested DxEGShDevData_display
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:376) retVal: 00000001
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:534) ReactX Calling : DxEngLockHdev
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:536) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:286) ReactX Calling : DxEngGetHdevData, Type: 2
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:289) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:303) requested DxEGShDevData_DitherFmt
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:376) retVal: 00000004
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:286) ReactX Calling : DxEngGetHdevData, Type: 7
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:289) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:323) requested DxEGShDevData_eddg
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:376) retVal: e1790008
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:571) ReactX Calling : DxEngUnlockHdev
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:157) ReactX Calling : DxEngUnlockDC
      		 
      (/win32ss/reactx/ntddraw/ddraw.c:365) Calling dxg.sys pfnDdReenableDirectDrawObject
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:181) ReactX Calling : DxEngLockShareSem
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:534) ReactX Calling : DxEngLockHdev
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:536) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:571) ReactX Calling : DxEngUnlockHdev
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:204) ReactX Calling : DxEngUnlockShareSem
      		 
      (/win32ss/reactx/ntddraw/ddraw.c:368) end Calling dxg.sys pfnDdReenableDirectDrawObject, status: 0x00000000
      		 
      (/win32ss/reactx/ntddraw/ddraw.c:292) Calling dxg.sys pfnDdDeleteDirectDrawObject(01200001)
      		 
      (/win32ss/reactx/ntddraw/ddraw.c:148) Calling dxg.sys pfnDdCreateDirectDrawObject
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:133) ReactX Calling : DxEngLockDC
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:456) ReactX Calling : DxEngGetDCState, type: 3
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:483) retVal: e178f3f0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:286) ReactX Calling : DxEngGetHdevData, Type: 12
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:289) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:343) requested DxEGShDevData_display
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:376) retVal: 00000001
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:534) ReactX Calling : DxEngLockHdev
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:536) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:286) ReactX Calling : DxEngGetHdevData, Type: 2
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:289) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:303) requested DxEGShDevData_DitherFmt
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:376) retVal: 00000004
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:286) ReactX Calling : DxEngGetHdevData, Type: 7
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:289) hDev: E178F3F0
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:323) requested DxEGShDevData_eddg
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:376) retVal: e1790008
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:571) ReactX Calling : DxEngUnlockHdev
      		 
      (/win32ss/reactx/ntddraw/dxeng.c:157) ReactX Calling : DxEngUnlockDC
      		 
      (/win32ss/gdi/eng/device.c:695) err: Could not open device \Device\Video1, 0xc0000022
      		 
      (/win32ss/gdi/eng/device.c:695) err: Could not open device \Device\Video1, 0xc0000022
      		 
      (/win32ss/gdi/eng/device.c:695) err: Could not open device \Device\Video1, 0xc0000022
      		 
      (/win32ss/gdi/eng/device.c:695) err: Could not open device \Device\Video1, 0xc0000022
      		 
      (/win32ss/reactx/ntddraw/ddraw.c:292) Calling dxg.sys pfnDdDeleteDirectDrawObject(01200002)
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      WARNING:  NtUserLockWindowUpdate at /win32ss/user/ntuser/ntstubs.c:914 is UNIMPLEMENTED!
      		 
      err:(/win32ss/user/imm32/imm.c:962) hImc was NULL
      		 
      err:(/win32ss/user/imm32/imm.c:1052) pClientImc was NULL
      		 
      err:(/win32ss/user/imm32/imm.c:962) hImc was NULL
      		 
      err:(/win32ss/user/imm32/imm.c:962) hImc was NULL
      		 
      err:(/win32ss/user/imm32/imm.c:1052) pClientImc was NULL

      It seems due to a failure on SetDIBitsToDevice:

      still need to analyze the edge case

      Confirmed: - with #define MaxScanLines 6000

      Due to hardcoded limit introduced on https://github.com/reactos/reactos/commit/12e1919e5efc1ffc47c673ff1b660a4fed5975ad

      Attachments

        1. 1.1.0_works_maxscanlines.png
          1.1.0_works_maxscanlines.png
          213 kB
        2. demo_works_maxscanlines.png
          demo_works_maxscanlines.png
          87 kB
        3. IMG_2145.gif
          IMG_2145.gif
          390 kB
        4. IMG_2147.jpeg
          IMG_2147.jpeg
          133 kB
        5. SetDIBitsToDevice failure.png
          SetDIBitsToDevice failure.png
          30 kB

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. CORE-12377 MS Office Word 2000 - wrong ordering of elements in the symbols bar

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              Unassigned Unassigned
              simonelombardo simonelombardo
              Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: