Details
Major Description
Steps to reproduce:
- Download R3dfox 128.14.1 ESR for Windows XP here: https://github.com/Eclipse-Community/r3dfox/releases/download/v128.14.1-XP/r3dfox_XP-v128.14.1.win32.portable.7z.
- Extract the contents from downloaded archive.
- Go to the directory where you extracted it, and double-click on "r3dfox_XP.exe".
After the window appears, it's completely hung and unresponsible. If to click on the menu, toolbar or tabs, it immediately crashes:
Looking to r3dfox.log
, it fails because of some unimplemented math functions in our UCRT:
WARNING: calling stub trunc(1790864484321.783688) |
WARNING: calling stub trunc(1790864484386.181868) |
WARNING: calling stub trunc(1790864484386.801282) |
It's spammed a lot, and then just before crash occurs:
WARNING: calling stub truncf(4.000000) |
WARNING: calling stub truncf(4.000000) |
WARNING: calling stub truncf(280.000000) |
WARNING: calling stub truncf(39.000000) |
and then:
Unhandled exception
|
ExceptionCode: 80000003 |
CS:EIP 1b:51321441 |
DS 23 ES 23 FS 3b GS 0 |
EAX: 0417a71c EBX: 00000036 ECX: 00000143 |
EDX: 1009113c EBP: 0417a6e4 ESI: 00000143 ESP: 0417a6e4 |
EDI: 5596c5ec EFLAGS: 00000202 |
Address:
|
<xul.dll:1321441> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
Frames:
|
<xul.dll:6ae8ba> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:9c8052> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:9c7d4f> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:9c7cc5> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:d96d14> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:f3ffe6> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:f4014d> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:f2d208> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:e8a459> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:e63898> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:e5685a> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:e4eeda> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:e4da6d> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<xul.dll:9c525e> (C:\Program Files\r3dfox_XP-v128.14.1.win32.portable\xul.dll@50000000) |
<kernel32.dll:1d128> (C:\ReactOS\system32\kernel32.dll@7c5e0000) |
It appears these functions are already implemented in upstream, while we don't have them yet. See https://git.musl-libc.org/cgit/musl/tree/src/math/trunc.c and https://git.musl-libc.org/cgit/musl/tree/src/math/truncf.c.
I've already imported them locally and will send a new PR with my change soon. 
I tested and confirm the browser starts and works (opens websites) correctly after my changes:
