Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-2937

rbuild: nested "if" bug

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Fix
    • Major
    • None
    • Tools
    • None
    • Operating System: ReactOS
      Platform: x86 Hardware

    Description

      Created an attachment (id=2471)
      patch

      Attached is a small Hal modules reorganization patch. I was trying to avoid using alias by using conditional logic.

      In hal\halx86\directory.rbuild we have :

      <if property="SARCH" value="">
      <module name="halup" type="kernelmodedll" entrypoint="0" >
      (...)
      </module>

      <module name="halmp" type="kernelmodedll" entrypoint="0" installname="halmp.dll">
      (...)
      </module>
      </if>

      <if property="SARCH" value="xbox">
      <module name="halup" type="kernelmodedll" entrypoint="0" allowwarnings="true" installname="hal.dll">
      (...)
      </module>
      </if>

      SARCH is defined as <property name="SARCH" value="" /> on config.template so modules halup and halmp should be included in the makefile.

      rbuild is just omitting both modules even the condition is meet. While debugging I have seen than rbuild is properly parsing the rbuild file but "if" child nodes are not executed.

      when "ifs" are removed the modules are created with any problem so rbuild is reading this file.

      I have also tried changing "if" with "ifnot" , the effect is the same , if the SARCH value was not "" the nodes should be executed but they are not. So it's clearly a bug

      Attached the patch to reproduce this problem

      Attachments

        Issue Links

          Activity

            People

              kjkhyperion kjkhyperion
              piulachs piulachs
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: