Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-3306

explorer: redeclaration of _pctype from const to static

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Major
    • None
    • Shell
    • None
    • Operating System: ReactOS
      Platform: x86 Hardware

    Description

      target file:
      base/shell/explorer/utility/utility.h

      like the reported in [3598], precompiling header for explorer may fail under certain build environments (and in this case, specifically under non-win32 hosts), overriding the declaration of _pctype.
      Below, the patch to fix this issue.

      Marcelo A. B. Slomp

      Index: base/shell/explorer/utility/utility.h
      ===================================================================
      — base/shell/explorer/utility/utility.h (revision 34860)
      +++ base/shell/explorer/utility/utility.h (working copy)
      @@ -25,6 +25,11 @@
      // Martin Fuchs, 23.07.2003
      //

      + // standard windows headers
      +#define WIN32_LEAN_AND_MEAN
      +#define WIN32_EXTRA_LEAN
      +#include <windows.h>
      +
      #ifdef __cplusplus

      #ifdef _MSC_VER
      @@ -39,11 +44,6 @@
      #endif /* __cplusplus */

      • // standard windows headers
        -#define WIN32_LEAN_AND_MEAN
        -#define WIN32_EXTRA_LEAN
        -#include <windows.h>
        -
        // Unicode support
        #if defined(UNICODE) && !defined(_UNICODE)
        #define _UNICODE

      Attachments

        Issue Links

          Activity

            People

              Colin Finck Colin Finck
              mslomp mslomp
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: