Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-4032

IntGdiAngleArc resets pPath->newStroke

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: Win32SS
    • Labels:
      None
    • Environment:

      Operating System: ReactOS
      Platform: x86 Hardware

      Description

      After drawing a still open path with AngleArc, the internal field newStroke is reset because of a call to IntGdiMoveToEx (which calls PATH_MoveTo to reset newStroke). This results in a (unneeded) MOVETO path operation if the path is continued afterwards.
      See gdi32 path test function test_anglearc for a testcase for this.
      Removing the IntGdiMoveToEx call fixes this problem and the related 11 path winetest, but i'm unsure why it was added - since the final point should be reached within the PATH_ARC function.

      Still the comment indicates some importance of that call (\reactos\subsystems\win32\win32k\objects\arc.c:298):
      IntGdiMoveToEx(pDC, x2, y2, NULL); // Dont forget Path

      Maybe PATH_MoveTo in IntGdiMoveToEx is expendable?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jimtabor jimtabor
                Reporter:
                grschneider Gregor Schneider
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: