Details
-
Bug
-
Resolution: Fixed
-
Major
-
None
-
None
-
Operating System: ReactOS
Platform: x86 Hardware
Description
Message in debug log: ERR: HCR_GetFolderAttributes should be called for simple PIDL's only!
Caused by explorer.exe when incorrectly calling IShellFolder::GetAttributesOf.
GetAttributesOf takes PIDLs only for "this" folder single level items.
Here is patch:
Index: shellfs.cpp
===================================================================
— shellfs.cpp (revision 40909)
+++ shellfs.cpp (working copy)
@@ -170,9 +170,12 @@
if (_folder.empty())
return false;
+ ShellPath pidlParent, pidlFolder;
+ _pidl.split(pidlParent, pidlFolder);
+
SFGAOF attribs = SFGAO_FILESYSTEM;
- if (FAILED(const_cast<ShellFolder&>(_folder)->GetAttributesOf(1, (LPCITEMIDLIST*)&_pidl, &attribs)))
+ if (FAILED(pidlParent.get_folder()->GetAttributesOf(1, (LPCITEMIDLIST*)&pidlFolder, &attribs)))
return false;
if (!(attribs & SFGAO_FILESYSTEM))