Core ReactOS
  1. Core ReactOS
  2. CORE-437

GetCurrentDirectory and GetTempPath broken

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: Win32SS
    • Labels:
      None
    • Environment:

      Operating System: ReactOS
      Platform: x86 Hardware

      Description

      GetCurrentDirectory and GetTempPath don't behave the way applications might
      expect them to. They even sometimes crash applications. I attached a simple test
      program that should output something like this in reactos (wine tests might test
      more thoroughly, but i haven't really looked at them):

      ==GetCurrentDirectoryA:
      :A: [23]
      :B: [23]
      :C: [22]: D:\rosapps\tests\hello
      :E: [23]: SUCCESS: Buffer untouched!
      :F: [23]: SUCCESS: Buffer untouched!
      ==GetCurrentDirectoryW:
      :A: [23]
      :B: [23]
      :C: [22]: D:\rosapps\tests\hello
      : [23]: SUCCESS: Buffer untouched!
      :E: [23]: SUCCESS: Buffer untouched!
      ==GetTempPathA:
      :A: [34]
      :B: [34]
      :C: [33]: C:\DOCUME~1\Thomas\LOCALS~1\Temp\
      : [34]: SUCCESS: Buffer untouched!
      :E: [34]: SUCCESS: Buffer untouched!
      ==GetTempPathW:
      :A: [34]
      :B: [34]
      :C: [33]: C:\DOCUME~1\Thomas\LOCALS~1\Temp\
      : [34]: SUCCESS: Buffer touched ""!
      : [34]: SUCCESS: Buffer touched ""!
      :E: [34]: SUCCESS: Buffer touched ""!
      :E: [34]: SUCCESS: Buffer touched ""!

      0 tests failed

      1. a2u.c
        0.5 kB
        GvG
      2. curdir.diff
        3 kB
        tinus
      3. curdir.patch
        7 kB
        weiden
      4. curdir2.diff
        6 kB
        Eric Kohl
      5. unic.diff
        1 kB
        tinus
      1. dirs.png
        27 kB

        Activity

        Hide
        Eric Kohl
        added a comment -

        Created an attachment (id=130)
        This patch fixes GetTempPathA/W and includes tinus' previous patch for
        GetCurrentDirectoryA/W.

        Show
        Eric Kohl
        added a comment - Created an attachment (id=130) This patch fixes GetTempPathA/W and includes tinus' previous patch for GetCurrentDirectoryA/W.
        Hide
        Eric Kohl
        added a comment -

        Attachment curdir2.diff has been added with description: This patch fixes GetTempPathA/W and includes tinus' previous patch for GetCurrentDirectoryA/W.

        Show
        Eric Kohl
        added a comment - Attachment curdir2.diff has been added with description: This patch fixes GetTempPathA/W and includes tinus' previous patch for GetCurrentDirectoryA/W.
        Hide
        weiden
        added a comment -

        Created an attachment (id=131)
        based on the patch by tinus and Eric this patch only includes one minor fix to
        GetTempPathA to make all test cases pass

        Show
        weiden
        added a comment - Created an attachment (id=131) based on the patch by tinus and Eric this patch only includes one minor fix to GetTempPathA to make all test cases pass
        Hide
        weiden
        added a comment -

        Attachment curdir.patch has been added with description: based on the patch by tinus and Eric this patch only includes one minor fix to GetTempPathA to make all test cases pass

        Show
        weiden
        added a comment - Attachment curdir.patch has been added with description: based on the patch by tinus and Eric this patch only includes one minor fix to GetTempPathA to make all test cases pass
        Hide
        weiden
        added a comment -

        I committed the patch, all test cases pass so I think it's the way it's supposed
        to work.

        Show
        weiden
        added a comment - I committed the patch, all test cases pass so I think it's the way it's supposed to work.

          People

          • Assignee:
            Bug Zilla
            Reporter:
            weiden
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: