Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-4708

Possibly uninitialized variables in BootVid.dll (reported by A. Khaldi)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • Drivers: Other
    • None
    • Operating System: ReactOS
      Platform: x86 Hardware

    Description

      Not to forget this thing...

      I. bootvid\i386\vga.c - "LeftArray" array elements might be used uninitialized in BitBlt().

      1 - vga.c:425: BitsPerPixel!=4 is false
      2 - vga.c:482: Height<=0 is false
      3 - vga.c:574: SomeYesNoFlag2 is true
      4 - vga.c:580: DistanceMinusLeftBpp>0 is true
      5 - vga.c:587: LeftArray array elements are used uninitialized.

      II. bootvid\i386\bootvid.c - "Value" might be used uninitialized in VgaInterpretCmdStream().

      1 - bootvid.c:21: CmdStream is true
      2 - bootvid.c:24: *CmdStream is true
      3 - bootvid.c:35: Major==16 is false
      4 - bootvid.c:133: Major==32 is true
      5 - bootvid.c:138: Minor==0 is true
      6 - bootvid.c:155: ShortValue is true
      7 - bootvid.c:158: Count is true
      8 - bootvid.c:158: Value is used, but is uninitialized.

      Attachments

        Activity

          People

            hbelusca hbelusca
            hto hto
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: