Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-5264

win32k: Add support for styled cosmetic lines / fix for gdi32:pen

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.0
    • Win32SS
    • None

    • Operating System: ReactOS
      Platform: x86 Hardware

    Description

      The attached patch adds support for styled cosmetic lines in the graphics engine of the Win32 subsystem. With one pixel width currently, but I'm interested in adding support for thick lines generally (http://reactos.org/bugzilla/show_bug.cgi?id=2761) if wanted.

      Please, a GDI guru of ROS should check if this is okay. I'm still not very familiar with all the GDI internals.

      It's not the fastest way doing it with PutPixel for Horizontal and Vertical lines for sure. There is still need for optimization.

      Futhermore this bug fixes test gdi32:pen

      http://www.reactos.org/testman/detail.php?id=1222526

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. CORE-9984 ReactOS does not draw tree view lines

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-5644 mspaint: selection border isn't visible

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-7165 Rectangle () doesn't draw with PS_DASH, PS_DOT, PS_DASHDOT,PS_DASHDOTDOT

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-5644 mspaint: selection border isn't visible

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. CORE-16243 [NTGDI] Implement EngFillPath

          • Major - Major loss of function.
          • Untriaged

          Activity

            People

              ThePhysicist Timo Kreuzer
              _ne0man _ne0man
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: