Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-5398

Crash with /FIRSTCHANCE clicking on "Computer name" tab of System Properties dialog

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Cannot Reproduce
    • Fix Version/s: 0.4.0
    • Component/s: Win32SS
    • Labels:
      None
    • Environment:

      Operating System: ReactOS
      Platform: x86 Hardware

      Description

      Desktop -> My computer -> right click -> Properties
      Select the Computer name tab. ReactOS crushed.

      I found the crush place: File: dll\win32\rpcrt4\ndr_marshall.c: Line nearly 6790.

      Cause:

          else
          {
              NDR_SCONTEXT ctxt = NDRSContextFromValue(pMemory);
      +       if ( NULL== pStubMsg->StubDesc->apfnNdrRundownRoutines ){
      +         ERR("Now will crush because of pStubMsg->StubDesc->apfnNdrRundownRoutines is null\n");
      +       }
              NDR_RUNDOWN rundown = pStubMsg->StubDesc->apfnNdrRundownRoutines[pFormat[2]]; //!! bug is here!
              NdrServerContextNewMarshall(pStubMsg, ctxt, rundown, pFormat);
          }

      ("+" marked lines are mine)

      pStubMsg->StubDesc->apfnNdrRundownRoutines is null and dereferenced.

      Would somebody correct this? returning just before crush from function doesn't help, it equally crushed

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              Mna. Mna.
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: