Details
-
Bug
-
Resolution: Fixed
-
Major
-
None
-
Operating System: ReactOS
Platform: x86 Hardware
Description
r54588
Go to C:\ReactOS and make shortcut to file folder 'Inf'.
Right click on 'Inf.lnk', properties. Target location in 'Shortcut' tab is missing.
There is 'Command prompt.lnk' file in desktop and it haves correct target location.
After investigate I have found out that it happens because there is trailing backslash at the end of pThis->sWorkDir.
Using this code in shelllink.cpp
/* target location */
int wLen = wcslen(pThis->sWorkDir);
wchar_t * wTrgtLocat;
if (wLen == 3)
else
{ wchar_t* pLastChar = _tcschr(pThis->sWorkDir, '\0'); pLastChar--; if ( *pLastChar == '\\' ) //Make sure we don't to pass extra '\' e.g 'C:\ReactOS\' pThis->sWorkDir[wcslen(pThis->sWorkDir) - 1] = '\0'; const int ch = '\\'; wTrgtLocat = wcsrchr(pThis->sWorkDir, ch)+1; }SetDlgItemTextW(hwndDlg, 14007, wTrgtLocat);
would fix things, but code seems like a hack.
And it might be similar to http://www.reactos.org/bugzilla/show_bug.cgi?id=6571 and http://www.reactos.org/bugzilla/show_bug.cgi?id=6725
Attachments
Issue Links
- relates to
-
CORE-5730 PATCH: shell32 show target location in shortcut properties
- Resolved