Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-6471

PATCH: advapi32 - services - Code cleaning and removing bugs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: ReactOS
      Platform: x86 Hardware

      Description

      Created an attachment (id=7803)
      Patch

      What it's done here :

      • Unneeded checks are removed :

      if (*lpServicesReturned > 0)
      {
      for (dwCount = 0; dwCount < *lpServicesReturned; dwCount++)
      ...

      now becomes:

      for (dwCount = 0; dwCount < *lpServicesReturned; dwCount++)
      ...

      • In EnumServicesStatusA :
      • A buggy check is removed, instead REnumServicesStatusA performs a valid version of this test (via REnumServicesStatusW and REnumServiceGroupW, see the next bug report).
      • Bad used type ENUM_SERVICE_STATUSW becomes ENUM_SERVICE_STATUSA.
      • In EnumServicesStatusW :
        We use the implementation of EnumServiceGroupW by passing NULL for the group name (the same thing is done in the SCM).
      • In EnumServicesStatusExW :
        Check whether the SC database handle is valid before performing any operations.

        Attachments

          Activity

            People

            • Assignee:
              ekohl ekohl
              Reporter:
              hbelusca hbelusca
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: