Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-6850

Move code that dereferences ConnectionPort into the if(ConnectionPort) block

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Fix Version/s: 0.4.2
    • Component/s: NTCore
    • Labels:

      Description

      The old code that dereferences ConnectionPort after if (ConnectionPort)

      { ... }

      This might not be a problem, since it depends on a condition that is probably never true when ConnectionPort is NULL, but it should probably still not be done on that path.
      It might as well be done further down, but doing it before ObDereferenceObject(ConnectionPort) seems to make sense.
      This is an old patch by Samuel.

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              ThePhysicist Timo Kreuzer
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: