Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-7031

msvcrt: add positional parameters support for ROS's printf* implementation

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: CRT
    • Labels:
    • Environment:

      ReactOS Build Environment for Unix-based Operating Systems
      Version 2.1

      Environment Information
      Selected Target Architecture: i386

      Build Tools
      gcc version 4.7.2 (RosBE-Unix)
      GNU ld (GNU Binutils) 2.23.51.20121208

      Description

      I found that these failing tests(http://www.reactos.org/sites/all/modules/reactos/testman/detail.php?id=7048475&prev=0) are caused by a missing feature positional parameters(http://msdn.microsoft.com/en-us/library/c8c2ax31(v=vs.80).aspx) in Reactos's msvcrt implementaion.So this patch is addressing this and add support for it. I have tested it against the R58613 bootcd, and all failing tests mentioned before pass.

      This patch modifies the most underlying interface streamout ,which all Reactos msvcrt printf* functions evetually resort to. It add a paramter to this interface , to indicate that if we are using positional paramters. If it is the case, we just fetch all the positional parameters from a passed-in pos_param array, which is generated by the first time parsing the format string before; if not the case, we just fall back to original path, and everything work as before.

      Signed-off-by : Zhan Jianyu <nasa4836@gmail.com>
      (This is my first time submitting to community, please excuse me if i do anything wrong.)

        Attachments

          Activity

            People

            • Assignee:
              ThePhysicist Timo Kreuzer
              Reporter:
              larmbr larmbr
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: