Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-7108

Refactor KmTest::FtRtlExpression tests.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • Other

    Description

      I've rewritten the testsuite so we can use just a Struct to feed FsRtlIsName and FsRtlIsDbcs with it.
      This makes much more sane and easy to add new testcases.

      I could reuse the same "for" loop for both tests in a really easy way, but I didn't in the sake of readibility, Imho i think is better if we have:
      FsRtlIsNameInExpressionTest();
      FsRtlIsDbcsInExpressionTest();

      Than if we have:
      FsRtlIsTest();

      Also, we can find (who knows) exceptional cases where both APIs works different with same parameters(wildcards are wild and comes from oldie times).

      I've added extra-Debug info by showing how the API was called to know which test has failed.
      And I've added a couple of new tests, and removed a duplicated one.

      Attachments

        Activity

          People

            ThFabba ThFabba
            vicmarcal vicmarcal
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: