Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-7563

shell32: shell icon cache and icon extractors need to be rewritten

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • Shell
    • None

    Description

      The code that loads icons is fully functioning however in order to fix all the issues with icons showing slow as hell we should consider rewriting the components that handle icons. For example we will benefit greatly in terms of user experience if we implement asynchronous icon extraction, accessing the icons in the SIC using a hash table, caching the icon cache in a file instead of rebuilding it in each boot, and implement any other features windows may have in these components. A rewrite will also use c++ classes instead of using the existing C interfaces. However these goals are not a priority and will only give a user experience improvement as the existing implementation is functioning. It's just sub optimal.

      Attachments

        1. async icon extraction.txt
          6 kB
          Giannis Adamopoulos
        2. iconcache.cpp.patch
          8 kB
          gigaherz
        3. icon-cache-wip.patch
          77 kB
          gigaherz

        Activity

          People

            gigaherz gigaherz
            Smiley Giannis Adamopoulos
            Votes:
            4 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated: