Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-8111

Fix bugs in DisplayEvent() and GetEventCategory() from EventVwr

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.3.17
    • Component/s: Applications
    • Labels:

      Description

      Two fixes:

      • DisplayEvent(): ListView_GetItemText expects the number of characters as the last param. However it is wrongly calculated.
      • GetEventCategory(): Fix the logic in the if..else case:
        a)The else was using a NULL buffer as wcscpy source, which could lead to a memory error. However this part of code is never reached because
        b)The if...else is just executed if FormatMessageW!=0. Since FormatMessageW returns the number of characters from the buffer, checking if the buffer is NULL is unneeded.

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              vicmarcal vicmarcal
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: