Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-8273

A call to GlobalAlloc was breaking explorer navigation history

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • Shell
    • None

    Description

      In CTravelEntry::Update, around browseui/travellog.cpp:176, there was a call to GlobalAlloc(GMEM_FIXED, 0) followed by a call to CreateStreamOnHGlobal(globalStorage, FALSE, &globalStream)

      In Windows, this did not cause any apparent issue. The Stream worked correctly and navigation history was working. But in ReactOS, the CreateStream call failed with E_OUTOFMEMORY.

      I do not know whether GlobalAlloc behaves differently in ReactOS, or the Windows implementation of the IStream is able to resize the HGLOBAL, but the ReactOS version can't do it.

      Since the call to CreateStream does not require an HGLOBAL, I have removed the GlobalAlloc and used NULL in CreateStreamFromHGlobal. This fixes the problem, and works both in Windows and ReactOS, but the underlying issue still remains.

      I'm not assigning a component since I don't know what causes the problem.

      Attachments

        Activity

          People

            Unassigned Unassigned
            gigaherz gigaherz
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: