Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-8441

ITEMIDLIST typedefs are messed up

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.0
    • Shell
    • None

    Description

      "typedef const PITEMID_CHILD PCITEMID_CHILD;" is just plain wrong (Wine issue).

      We are completely inconsistent in our headers regarding the difference between absolute, relative, and child ID lists. Ideally, we should support STRICT_TYPED_ITEMIDS in our headers and enable it in shell (or preferable all) code.

      Attachments

        1. idlist-compile-fix-with-shtypes-fix.patch
          9 kB
          gigaherz
        2. idlist-shell32-folders.patch
          73 kB
          ThFabba
        3. idlist-shell32-fs.patch
          8 kB
          ThFabba
        4. shobjidl-fix-some-idlists.patch
          2 kB
          ThFabba
        5. shobjidl-fix-some-idlists.patch
          2 kB
          ThFabba
        6. shtypes-fix-itemidlists.patch
          2 kB
          gigaherz
        7. shtypes-fix-itemidlists.patch
          2 kB
          ThFabba

        Issue Links

          Activity

            People

              ThFabba ThFabba
              ThFabba ThFabba
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: